-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inherit from dbt-sqlserver #32
Conversation
I have now moved the repo to dbt-msft. So lets add the versions.py and try. Should we add dbt-sqlserver as a dependency in setup.py as well? |
remove redundant logic
This looks neat! Hope we can get this going. It would be much easier maintenance of both adapters. |
Agreed! This PR is top of my list |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jtcohen6 still a good chunk of work to be done here I think, but blocked in a weird way w/ the drop_relation()
macro...
dbt/include/synapse/macros/materializations/snapshot/strategies.sql
Outdated
Show resolved
Hide resolved
use the inhieritance, luke
…dbt-synapse into inherit-from-sqlserver
8d8c452
to
f528e23
Compare
@jtcohen6 it's finally ready! thanks for holding my hand through this. |
@swanderz Amazing!! That makes sense to me. We'll be releasing |
untested code! just to give a sense of what this looks like
Based on / copied from:
dbt-postgres
→dbt-redshift
inheritance (relevant files)setup.py
fromdbt-spark
for reporting versionSQL Strategies
If you need a Jinja adapter macro to do something genuinely different from the implementation in dbt-sqlserver, it's as simple as reimplementing it with a
synapse__
prefix instead.Today, if you want a macro to do exactly the same thing, you still need to reimplement it, but you can just wrap the sqlserver version:
There's a change I'd like to make for dispatched macros (dbt-labs/dbt-core#2923) which will enable you to completely avoid reimplementing macros if the
synapse__
version is the same as thesqlserver__
version. (I currently have it under the v0.20.0 milestone.)